Replace recursive topological sort with iterative algorithm #25
Conversation
| * the topologic sorting may be non-unique depending on your edges. this | ||
| * algorithm tries to keep the order of vertices as added to the graph in | ||
| * this case. | ||
| * the topological sorting may be non-unique depending on your edges |
There was a problem hiding this comment.
Was this removed intentionally? If so, should this be considered a BC break? Can you add some test cases for this?
There was a problem hiding this comment.
I don't think it should be considered BC - I'm not sure the topsort should not have made any potential promises about the ordering in the first place.
There was a problem hiding this comment.
I'm not sure the topsort should not have made any potential promises about the ordering in the first place.
I agree that it should not have made this promise in the first place.
That being said, I suppose this is something some projects may currently rely on it. As such, I'm marking this as a BC break just in case and will merge this as-is.
Again, thank you! 👍
@Gillu13 Yes, the original concept aimed to keep the original order. This is not currently documented, so I do not consider this to be a BC break and have just changed the milestone accordingly 👍 |
No description provided.