Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split off algorithms #119

Closed
clue opened this issue Jan 12, 2015 · 3 comments · Fixed by #124
Closed

Split off algorithms #119

clue opened this issue Jan 12, 2015 · 3 comments · Fixed by #124

Comments

@clue
Copy link
Member

clue commented Jan 12, 2015

Goal: Stabilizing the core graph library (plain Graph, Vertices and Edges)

The current set of algorithms is certainly what sets this library apart from other existing graph libraries. However, they're also a constant source of changes, issues and BC breaks. Also, quite a few users of this library probably won't even use a single algorithm.

As such, I'd like to split of the whole Algorithm namespace into a separate package. This is a short-term solution to this problem. Ideally, we should consider splitting this package into even more dedicated packages. This will add quite some maintenance overhead, so I'd like to postpone this until there's an actual demand.

The suggested package name would be "graphp/algorithms". Any input is welcome!

[Edit: axed] Marking this ticket as "blocked", as there are quite a few PRs and issues that need review first. Splitting this off now means that we should migrate all outstanding PRs and issues over.

Any input is very much appreciated!

Refs #120.

@clue
Copy link
Member Author

clue commented Feb 25, 2015

Marking this ticket as "blocked", as there are quite a few PRs and issues that need review first. Splitting this off now means that we should migrate all outstanding PRs and issues over.

Waiting for all tickets to be resolved before splitting this off means we would end up waiting for an unknown period of time with no way to move forward.

As an alternative, we will have to make a clean cut and reject all outstanding PRs.

I wholeheartedly understand that this might be frustrating for PR authors. To mitigate this, we should work towards supporting each one to get this migrated to the final target repository.

@dav-m85
Copy link

dav-m85 commented Feb 25, 2015

Fair enough. Frustrated indeed, but happy the project keeps rollin :) Thanks for your watch !

@clue
Copy link
Member Author

clue commented Mar 4, 2015

Thanks for your understanding @dav-m85! Now let's get your outstanding PRs in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants