[WIP] Support undirected graphs for Algorithm\ShortestPath #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each algorithm only implements the new method which returns an intermediary result. The dedicated Result interface implements the common accessors and avoids running the algorithm again. Added a BC layer for now, which forwards all method calls.
The new algorithms now use a smaller signature and avoid passing the start Vertex to the ctor. Keep a BC layer for now.
Conflicts: lib/Fhaculty/Graph/Algorithm/ShortestPath/MooreBellmanFord.php tests/Fhaculty/Graph/Algorithm/ShortestPath/BaseShortestPathTest.php tests/Fhaculty/Graph/Algorithm/ShortestPath/MooreBellmanFordTest.php
The new design allows for a much cleaner implementation. This now also works for undirected edges just as well. Fixes #66
|
The good news:
The bad news:
So while the end result looks good to me, it's quite difficult to work with. To clean things up a bit, I'll have to rework this whole thing and introduce smaller, independent changesets. Obviously, this will take some time. So if anybody wants to test out the results and check if this branch fixes #66, go ahead :) But expect this to take some time until it can actually be merged. |
Closed
|
All algorithms will be split off to a separate package graphp/algorithms (see also #119 for some background). As such, this PR can no longer be merged into this repo. That being said, I'd still love this see this in! I've filed a new ticket as a reminder to keep track of this PR until it has been migrated over. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a WIP ticket to keep track of the current status to actually support undirected graphs for Dijkstra and MooreBellmanFord.
Refs #66 (original bug report + lengthy details on what needs to be done) and supersedes #68 (initial attempt).