Fix issues with links and images in substreams docs #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Next.js Bundle Analysis for @graphprotocol/docsThis analysis was generated by the Next.js Bundle Analysis action. 🤖
|
| Page | Size (compressed) |
|---|---|
global |
596.71 KB (🟡 +25 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
benface
commented
May 11, 2023
| // close img tags only if he doesn't point to .gitbook | ||
| .replaceAll(/<img(.*?)>/g, (...m) => (m[1].includes('src=".gitbook') ? '' : `<img${m[1]}/>`)) | ||
| // close unclosed img tags | ||
| .replaceAll(/<img((?:(?!\/>)[^>])*?)>/g, (...m) => `<img${m[1]}/>`) |
There was a problem hiding this comment.
I totally didn't use AI for this. 😄
saihaj
approved these changes
May 12, 2023
dotansimha
approved these changes
May 13, 2023
# Conflicts: # website/pages/en/substreams/[[...slug]].mdx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following issues reported by @Web3Slimchance, as well as a broken image on
/en/substreams/concepts-and-fundamentals/fundamentals/:/en/substreams/reference-and-specs/command-line-interface/, "defined in the Substreams manifest" linked to/en/substreams/manifests/#modules-.namewhich is a 404. Now correctly links to/en/substreams/reference-and-specs/manifests/#modules-.name./en/substreams/developers-guide/overview/, "Read through the fundamentals" and "modules overview" were both 404s because they were missing the "substreams" URL segment.