graph, store: Remove GRAPH_ACCOUNT_TABLES setting #3525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leoyvens
reviewed
May 5, 2022
| let immutable = defn.is_immutable(); | ||
|
|
||
| let table = Table { | ||
| object: EntityType::from(defn), | ||
| name: table_name, | ||
| qualified_name, | ||
| is_account_like, | ||
| is_account_like: false, |
There was a problem hiding this comment.
Why not check catalog::account_like here?
There was a problem hiding this comment.
We don't have a db connection at that point - but the flag is immediately updated in LayoutCache::load which is the only place that calls Layout::new (and in turn Table::new) in the code
There was a problem hiding this comment.
Got it, that seems worth a comment here.
leoyvens
approved these changes
May 5, 2022
Setting tables to account-like should now be done with `graphman stats account-like`. This setting was a holdover from before this command was available.
lutter
force-pushed
the
lutter/account-tables
branch
from
84bb9b0
to
2c88e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting tables to account-like should now be done with
graphman stats account-like. This setting was a holdover from before this command was available.