add 'send_all_block_headers' param for blockHandler #3971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduchesneau
force-pushed
the
stepd/firehose_block_headers_only
branch
from
a167690
to
d4a4a19
Compare
mangas
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a performance optimization for Block Handlers (requires firehose-ethereum > 1.1.0 to be deployed)
Instead of disabling the CombinedFilter, it will now use the CombinedFilter with:
SendAllBlockHeaders: true(new field)This requests that the firehose filter out all the transactions, but still send the block header.
In the case where we also want to match Calls and Logs, it will also use the
SendAllBlockHeaders: trueparameter, but will include the appropriate Call/Log filters.