Improve pruning #4125
Merged
Improve pruning #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evaporei
approved these changes
Nov 4, 2022
| table.switch(conn, self)?; | ||
| cancel.check_cancel()?; | ||
| conn.transaction(|| table.switch(conn, self))?; | ||
| cancel.check_cancel().map_err(CancelableError::from)?; |
There was a problem hiding this comment.
Why wasn't this needed before?
There was a problem hiding this comment.
I think it was because before the closure was declared as returning an error CancelableError<StoreError> of and after the change the typechecker needed this hint to find the conversions from Canceled -> CancelableError -> StoreError
Copying of nonfinal entity versions happened in one very long transaction, which can have terrible consequences for the rest of the system. We now break that transaction up into multiple transactions.
No functional change, just switch to using raw strings
This makes it possible to handle tables that do not live in the same namespace as the overall layout
That makes it possible to use the exact same structure, index names etc. for the temporary table as for the main table, so that we don't have to do complex renaming of indexes when swapping tables.
If we wait for the lock inside a transaction, we might cause a long-running transaction which we need to avoid. Instead, poll for the deployment lock before starting the actual transaction for writing changes or reverting.
The counting itself can take considerable amounts of time, and doesn't seem to help copying of final rows all that much.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pruning code could cause long running transactions which are problematic because they cause bloat in frequently updated tables, most notably
subgraph_deployment. This PR changes the pruning code to perform all operations in transactions that are time-limited (no more than 5 minutes)