store: Go back to the less clever but correct way of pruning #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change in aea5b57 has a logic error in that we look at a fixed number of rows from the table, filter out the ones we don't need to copy, and then insert the remaining rows. The error is that the logic assumes that if we do not insert any rows that we are done with copying, but that's wrong, since not inserting rows now just means that no rows in the batch needed to be copied even though a subsequent batch might still have such rows. This reverts commit aea5b57.
neysofu
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in aea5b57 has a logic error in that we look at a fixed number of rows from the table, filter out the ones we don't need to copy, and then insert the remaining rows. The error is that the logic assumes that if we do not insert any rows that we are done with copying, but that's wrong, since not inserting rows now just means that no rows in the batch needed to be copied even though a subsequent batch might still have such rows.
This reverts commit aea5b57.