Allow retrieving query traces over HTTP #4243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes, if the request header
X-GraphTraceQuery
is set to the right value, the response to a GraphQL query will include a trace of the SQL queries that were run to generate the GraphQL response. That trace looks likeSince generating traces can be expensive, the right value for
X-GraphTraceQuery
is configurable through the environment variableGRAPH_GRAPHQL_TRACE_TOKEN
; only if the header contains that token will a trace be generated.This PR also simplifies the usage of
graphman query
: it is no longer necessary to setGRAPH_LOG_QUERY_TIMING
when running it to get the query output and trace from the command line. The JSON thatgraphman query
generates as a trace is the same as is returned for HTTP queries, and much more readable than it was before.