bump substreams client to sf.substreams.rpc.v2.Stream/Blocks #4556
Conversation
This breaks compatibility with previous substreams servers that only support 'sf.substreams.v1.Stream/Blocks'
chain/substreams/src/mapper.rs
Outdated
| match message { | ||
| Some(SubstreamsMessage::BlockUndoSignal(undo)) => { | ||
| let valid_block = match undo.last_valid_block { | ||
| None => return Err(SubstreamsError::MissingClockError), |
There was a problem hiding this comment.
This should prolly have a different error message?
chain/substreams/src/mapper.rs
Outdated
| panic!("unknown step should not happen in the Firehose response") | ||
| } | ||
| } | ||
| None => { |
There was a problem hiding this comment.
Could you add a comment describing when this should happen?
chain/substreams/src/mapper.rs
Outdated
| } | ||
| } | ||
| None => { | ||
| //warn!(&logger, "Got None on substream message"); |
There was a problem hiding this comment.
Is it worth adding an informative logging message? If not then this can be removed
|
|
||
| tonic_build::configure() | ||
| .protoc_arg("--experimental_allow_proto3_optional") | ||
| .extern_path(".sf.substreams.v1", "crate::substreams") |
There was a problem hiding this comment.
this should be sf.substreams.rpc.v2 right?
There was a problem hiding this comment.
no, the sf.substreams.v1 still exists for the packages, manifests and such. Only, the service layer in it has been deprecated and moved to sf.substreams.rpc.v2 (the v2 to avoid confusion, even if we change namespace)
this extern_path directive informs the rpcv2 tonic handler about where to find the sf.substreams.v1 stuff.
* bump substreams client to sf.substreams.rpc.v2.Stream/Blocks This breaks compatibility with previous substreams servers that only support 'sf.substreams.v1.Stream/Blocks' * adjust substreams mapper code branches for clarity * add comments to clarify intent when ignoring useless substreams messages --------- Co-authored-by: Stéphane Duchesneau <[email protected]> Co-authored-by: Eduard Voiculescu <[email protected]>
Update substreams protocol to sf.substreams.rpc.v2.Stream/Blocks
This breaks compatibility with previous substreams servers that only support 'sf.substreams.v1.Stream/Blocks'