Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to pause and resume subgraphs #4642

Merged
merged 6 commits into from
Jun 2, 2023
Merged

Add ability to pause and resume subgraphs #4642

merged 6 commits into from
Jun 2, 2023

Conversation

incrypto32
Copy link
Member

@incrypto32 incrypto32 commented May 24, 2023 •
edited
Loading

Closes #4255

  • Schema changes to subgraph_deployment_assignment to include paused_at and assigned_at
  • Add pause_subgraph and resume_subgraph methods to store
  • Graphman commands pause and resume
  • Send StoreEvents EntityChangeOperation::Set and EntityChangeOperation::Remove
  • Ignore paused subgraphs on startup

lutter
lutter reviewed May 24, 2023
View reviewed changes
Copy link
Collaborator

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, some small comments

store/postgres/src/primary.rs Outdated Show resolved Hide resolved
store/postgres/src/primary.rs Outdated Show resolved Hide resolved
node/src/manager/commands/assign.rs Outdated Show resolved Hide resolved
store/postgres/src/primary.rs Outdated Show resolved Hide resolved
graph/src/components/store/traits.rs Outdated Show resolved Hide resolved
@incrypto32 incrypto32 force-pushed the incrypto32/pause-resume-subgraphs branch 2 times, most recently from e795d7a to 0f1ca0c Compare May 25, 2023 13:38
@incrypto32 incrypto32 force-pushed the incrypto32/pause-resume-subgraphs branch from 0f1ca0c to 046dd41 Compare May 25, 2023 13:38
@incrypto32 incrypto32 marked this pull request as ready for review May 25, 2023 13:50
@incrypto32 incrypto32 requested a review from lutter May 25, 2023 13:55
lutter
lutter approved these changes Jun 1, 2023
View reviewed changes
Copy link
Collaborator

@lutter lutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will be very useful

@incrypto32 incrypto32 merged commit 7f136f6 into master Jun 2, 2023
@incrypto32 incrypto32 deleted the incrypto32/pause-resume-subgraphs branch June 4, 2023 02:50
@incrypto32 incrypto32 mentioned this pull request Jun 5, 2023
Closed
2 tasks
@incrypto32 incrypto32 self-assigned this Jul 20, 2023
@paymog
Copy link

paymog commented Sep 7, 2023

if I'm understanding this PR correctly, graphman directly interacts with postgres when pausing/resuming. Is that correct? If so, it would be great if this functionality was also exposed as an endpoint on the graph node itself so that other applications could use this feature.

aasseman added a commit to aasseman/launchpad-charts that referenced this pull request Mar 23, 2024
@aasseman
feat(graph-node): add paused_at to indexing-status dashboard
91366b2 
paused_at was added with graphprotocol/graph-node#4642, added in graph-node v0.32.0

Signed-off-by: Alexis Asseman <[email protected]>
@aasseman aasseman mentioned this pull request Mar 23, 2024
Merged
chriswessels pushed a commit to graphops/launchpad-charts that referenced this pull request Mar 25, 2024
@aasseman
feat(graph-node): add paused_at to indexing-status dashboard (#265)
1d9bc11 
paused_at was added with graphprotocol/graph-node#4642, added in graph-node v0.32.0

Signed-off-by: Alexis Asseman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lutter lutter lutter approved these changes

Assignees

@incrypto32 incrypto32

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support pause/resume of subgraphs
3 participants
@incrypto32 @paymog @lutter