Fix panic on first startup when mixing firehose and rpc #4680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neysofu
requested changes
Jun 7, 2023
node/src/main.rs
Outdated
| @@ -305,17 +305,22 @@ async fn main() { | |||
| // `blockchain_map`. | |||
| let mut blockchain_map = BlockchainMap::new(); | |||
|
|
|||
| // Unwraps: `connect_ethereum_networks` and `connect_firehose_networks` only fail if if | |||
leoyvens
force-pushed
the
leo/fix-first-startup-when-mixing-firehose-and-rpc
branch
from
32da7f0
to
9161255
Compare
neysofu
approved these changes
Jun 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code was a bit convoluted because we used a
Vec<ChainIdentifier>, only to later validate in the store that the vec contained exactly one identifier, which make sense since we don't want conflicting identifiers for a same network. So the data structure is changed toBTreeMap<String, ChainIdentifier>, which naturally allows for de-duplicating the identifier between RPC and firehose providers, and also makes it easy to prefer the RPC identifier.Fixes #4655.