Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Include blockhash and number in eth_call debug logs #4718

Merged
merged 1 commit into from
Jun 23, 2023
Merged

[Feature] Include blockhash and number in eth_call debug logs #4718

merged 1 commit into from
Jun 23, 2023

Conversation

SozinM
Copy link
Contributor

@SozinM SozinM commented Jun 23, 2023

This closes issue #4698
Example of new debug logs:

DEBG eth_call, block_number: 16498903, block_hash: edabdef6666290010449e023eeb28b523dea6c46235bdd8b2d46ce689478697d, data: 70a0823100000000000000000000000038a8e16951352bab0cfd8872b881cd6bfdab25c8, address: dac17f958d2ee523a2206206994597c13d831ec7, sgd: 47, subgraph_id: QmUGnnNmiB3rTi1AFY4XKZWQ1z8kxKK6p1nFXL6wyyUo2r, component: SubgraphInstanceManager

Bloch hash does not have 0x at the start as all log entries that I saw in this repo had the same format

@SozinM SozinM changed the title Add block and block_hash data to eth_call debug logs [Feature] Include blockhash and number in eth_call debug logs Jun 23, 2023
incrypto32
incrypto32 approved these changes Jun 23, 2023
View reviewed changes
Copy link
Member

@incrypto32 incrypto32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leoyvens leoyvens merged commit 88c713f into graphprotocol:master Jun 23, 2023
@SozinM SozinM deleted the feature/eth_call_logs branch July 6, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@incrypto32 incrypto32 incrypto32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SozinM @incrypto32 @leoyvens