[Feature] A new graphman command to restart a subgraph #4742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
requested changes
Jul 10, 2023
NEWS.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| - `graphman` now has two new commands `pause` and `resume` that can be used to pause and resume a deployment | |||
| - A new table `subgraph_features` is added which tracks information like spec_version, api_version, network, features, datasources etc | |||
| - The schema for the `subgraphFeatures` endpoint now includes data from the `subgraph_features` table | |||
| - `graphman` now has new command `restart` that can be used to sequenteally pause and resume a deployment | |||
| sleep: Duration, | ||
| ) -> Result<(), Error> { | ||
| pause_or_resume(primary.clone(), sender, search, true)?; | ||
| thread::sleep(sleep); |
There was a problem hiding this comment.
Would be great to print out a message to console.. saying something like "Waiting for x seconds"
Actually might be good to have a "Pausing "
and a "resuming too
There was a problem hiding this comment.
New logs format:
pausing QmTGXDUdbYNuThTAUbeSA15BcQCRxX6qR1PyPN23e3JXFJ[210]
Operation completed
Waiting 20s to make sure pausing was processed
resuming QmTGXDUdbYNuThTAUbeSA15BcQCRxX6qR1PyPN23e3JXFJ[210]
Operation completed
added 2 commits
July 10, 2023 19:58
Add logs with sleep duration to restart command
|
Great job, thanks! |
incrypto32
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4715
Kept sleep param similar to rewind command