Optimize log filtering in blockstream #5015
Conversation
incrypto32
force-pushed
the
krishna/log-filter-optimisation
branch
from
1b9d5ef
to
b1fa9ce
Compare
chain/ethereum/src/trigger.rs
Outdated
| } | ||
| } | ||
|
|
||
| impl PartialEq for LogRef { |
There was a problem hiding this comment.
Where is this impl being relied on exactly?
There was a problem hiding this comment.
graph-node/chain/ethereum/src/trigger.rs
Line 303 in b1fa9ce
Its relied in impl PartialEq for EthereumTrigger
There was a problem hiding this comment.
I find it weird that this compares the receipt field given that it is optional, seems wrong really. Lets not have this impl, and inline the logic into EthereumTrigger as it was before. That code is critical for correct ordering of the triggers so I find that less indirection makes it easier to read. Also lets stop comparing the receipt, because it's optional, and instead compare only on transaction_hash and log_index.
There was a problem hiding this comment.
@leoyvens clarifying i understand this right, should we remove the previously existing comparison of the optional receipt right? Or should we just inline the logic and keep the original comparison of the optional receipt?
There was a problem hiding this comment.
We should remove the previously existing comparison.
There was a problem hiding this comment.
done!
I'll run it through the integration cluster
incrypto32
force-pushed
the
krishna/log-filter-optimisation
branch
2 times, most recently
from
1bd6d11
to
11a4fea
Compare
…r EthereumTrigger
incrypto32
force-pushed
the
krishna/log-filter-optimisation
branch
from
11a4fea
to
0bb45a0
Compare
incrypto32
force-pushed
the
krishna/log-filter-optimisation
branch
from
ee6a439
to
894e61d
Compare
chain/ethereum/src/data_source.rs
Outdated
| @@ -399,7 +399,11 @@ impl DataSource { | |||
|
|
|||
| fn handlers_for_log(&self, log: &Log) -> Result<Vec<MappingEventHandler>, Error> { | |||
There was a problem hiding this comment.
Can this no longer return Result?
No description provided.