Add history_blocks to manifest #5032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
incrypto32
force-pushed
the
krishna/indexer-hints
branch
from
482e205
to
9316ca1
Compare
incrypto32
commented
Nov 30, 2023
| #[derive(Debug, Deserialize)] | ||
| #[serde(rename_all = "camelCase")] | ||
| pub struct IndexerHints { | ||
| pub history_blocks: Option<BlockNumber>, |
There was a problem hiding this comment.
@leoyvens how does this look? If we have ongoing pruning do we need to the prune hint to do the manual pruning?
indexingHints:
prune:
historyBlocks: 100
lutter
approved these changes
Dec 6, 2023
| let manifest = resolve_manifest(YAML, SPEC_VERSION_0_0_4).await; | ||
|
|
||
| assert_eq!("Qmmanifest", manifest.id.as_str()); | ||
| assert!(manifest.indexer_hints.unwrap().prune.is_some()); |
There was a problem hiding this comment.
I don't understand this test - what is this trying to ensure?
There was a problem hiding this comment.
Oh i used that test to test out the indexer_hints parsing is working properly.
There was a problem hiding this comment.
its was removed already. merging
There was a problem hiding this comment.
Just a comment what the intent of the test was would have been fine, too - it was just a bit confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3667