Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error log #5217

Merged
merged 2 commits into from
Feb 22, 2024
Merged

improve error log #5217

merged 2 commits into from
Feb 22, 2024

Conversation

mangas
Copy link
Contributor

@mangas mangas commented Feb 19, 2024

Improve substreams block stream error reporting.

@@ -308,7 +308,7 @@ async fn process_substreams_response<C: Blockchain, F: BlockStreamMapper<C>>(
match mapper
.to_block_stream_event(logger, response.message, log_data)
.await
.context("Mapping message to BlockStreamEvent failed")?
.map_err(BlockStreamError::from)?
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Context was turning this error into a anyhow Error which was in turn then not showing the full details of the underlying error

@mangas mangas force-pushed the improve-err-log branch 2 times, most recently from 055bfe3 to 614892d Compare February 20, 2024 09:02
@mangas mangas merged commit f5eda50 into master Feb 22, 2024
7 checks passed
@mangas mangas deleted the improve-err-log branch February 22, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants