Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable Field.Resolve from JSON export #284

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Disable Field.Resolve from JSON export #284

merged 1 commit into from
Feb 23, 2018

Conversation

JulienBreux
Copy link
Contributor

@JulienBreux JulienBreux commented Feb 21, 2018 •
edited
Loading

Hello,

I've just add json:"-" to this line Resolve FieldResolveFn to allow JSON export of Field.

Thanks for this amazing project and time!

— JBX

@coveralls
Copy link

coveralls commented Feb 21, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 81.034% when pulling e97cb54 on JulienBreux:patch-1 into 1c504cf on graphql-go:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 81.034% when pulling e97cb54 on JulienBreux:patch-1 into 1c504cf on graphql-go:master.

@chris-ramon
Copy link
Member

lgtm 🚢 — thanks a lot @JulienBreux

@chris-ramon chris-ramon merged commit a881484 into graphql-go:master Feb 23, 2018
@JulienBreux JulienBreux deleted the patch-1 branch February 23, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JulienBreux @coveralls @chris-ramon