Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race in Execute #459

Merged
merged 3 commits into from
Apr 2, 2019
Merged

Fix data race in Execute #459

merged 3 commits into from
Apr 2, 2019

Conversation

egonelbre
Copy link
Contributor

Fixes #458

@coveralls
Copy link

coveralls commented Mar 10, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.008%) to 92.346% when pulling e637bd9 on egonelbre:data-race into 2b0b734 on graphql-go:master.

@egonelbre
Copy link
Contributor Author

Ping @chris-ramon

Fontinalis
Fontinalis approved these changes Apr 2, 2019
View reviewed changes
Copy link
Collaborator

@Fontinalis Fontinalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 - Thanks for your contribution @egonelbre , nice fix!

@Fontinalis Fontinalis merged commit bed865f into graphql-go:master Apr 2, 2019
@egonelbre egonelbre deleted the data-race branch April 2, 2019 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fontinalis Fontinalis Fontinalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@egonelbre @coveralls @Fontinalis