Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More easier to extend error #550

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

More easier to extend error #550

wants to merge 3 commits into from

Conversation

sunfuze
Copy link

@sunfuze sunfuze commented Jun 22, 2020 •
edited
Loading

we can return our custom error which imply interface gqlerrors.ExtendedError instead of new a gqlerrors.Error.

And remove unnecessary gqlerrors.FormattedError embed.

@sunfuze
More easier to extend error
e878f87 
we can return our custom error which imply interface gqlerrors.ExtendedError
instead of new a sqlerrors.Error
@coveralls
Copy link

coveralls commented Jun 22, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 92.376% when pulling 01213ee on sunfuze:error-extends-easier into 9441c49 on graphql-go:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sunfuze @coveralls