Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add async-graphql integration #5632

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

XiNiHa
Copy link

@XiNiHa XiNiHa commented Oct 1, 2024

Blocked by async-graphql/async-graphql#1606 to be merged

Background

Support for async-graphql was lacking.

Description

  • Extract core integration functionalities from Apollo Router plugin
  • Add async-graphql extension for Hive integration

Checklist

  • Input validation
  • Output encoding
  • Authentication management
  • Session management
  • Access control
  • Cryptographic practices
  • Error handling and logging
  • Data protection
  • Communication security
  • System configuration
  • Database security
  • File management
  • Memory management
  • Testing

Copy link

changeset-bot bot commented Oct 1, 2024

⚠️ No Changeset found

Latest commit: bc7ed52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

axum = ["dep:axum-core", "dep:http"]

[dependencies]
async-graphql = { git = "https://github.com/XiNiHa/async-graphql.git", rev = "16785021140660f8d62b85c17fec51428f4eb523" }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can also just land it with your fork temporarily until the blocked PR is merged, cc @dotansimha @kamilkisiela

Copy link
Collaborator

@YassinEldeeb YassinEldeeb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works well on my local too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants