Skip to content

Commit

Permalink
deprecate graphql@15 support (#3782)
Browse files Browse the repository at this point in the history
  • Loading branch information
acao authored Sep 15, 2024
1 parent 53c4b2c commit 6b88593
Show file tree
Hide file tree
Showing 13 changed files with 33 additions and 12 deletions.
16 changes: 16 additions & 0 deletions .changeset/neat-houses-explode.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
---
'graphql-language-service-server': minor
'@graphiql/plugin-code-exporter': minor
'graphql-language-service-cli': minor
'@graphiql/plugin-explorer': minor
'graphql-language-service': minor
'codemirror-graphql': minor
'@graphiql/toolkit': minor
'@graphiql/react': minor
'monaco-graphql': minor
'cm6-graphql': minor
'graphiql': minor
---

officially deprecate graphql@15 support, as our types and other runtime capabilities ceased to be compatible in 2022 or 2023, but the regression tests were disabled
`graphql-language-service` is where the bug is, which is used by all of the libraries and applications in `graphiql` monorepo.
7 changes: 6 additions & 1 deletion .github/workflows/pr-graphql-compat-check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,12 @@ jobs:
strategy:
matrix:
release:
['15.5.3', '^15.8.0', '16.1.0', '16.2.0', '16.3.0', '17.0.0-alpha.7']
# test against the latest 16.x version, which might be newer than what we have
- '^16'
# test against the oldest version we support
- '^16.0.0'
# test against the latest alpha
- '^17.0.0-alpha'
steps:
- name: Checkout Code
uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion packages/cm6-graphql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
"@codemirror/state": "^6.0.0",
"@codemirror/view": "^6.0.0",
"@lezer/highlight": "^1.0.0",
"graphql": "^16.5.0 || ^17.0.0-alpha.2"
"graphql": "^16.5.0"
},
"license": "MIT"
}
2 changes: 1 addition & 1 deletion packages/codemirror-graphql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"peerDependencies": {
"@codemirror/language": "6.0.0",
"codemirror": "^5.65.3",
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2"
"graphql": "^16.0.0"
},
"// TEMPORARILY PINNED until we fix graphql 15 support": "",
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/graphiql-plugin-code-exporter/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
},
"peerDependencies": {
"@graphiql/react": "^0.26.0",
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2",
"graphql": "^16.0.0",
"react": "^16.8.0 || ^17 || ^18",
"react-dom": "^16.8.0 || ^17 || ^18"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/graphiql-plugin-explorer/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
},
"peerDependencies": {
"@graphiql/react": "^0.26.0",
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2",
"graphql": "^16.0.0",
"react": "^16.8.0 || ^17 || ^18",
"react-dom": "^16.8.0 || ^17 || ^18"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/graphiql-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"build": "tsc --emitDeclarationOnly && vite build"
},
"peerDependencies": {
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2",
"graphql": "^16.0.0",
"react": "^16.8.0 || ^17 || ^18",
"react-dom": "^16.8.0 || ^17 || ^18"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/graphiql-toolkit/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"tsup": "^8.2.4"
},
"peerDependencies": {
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2",
"graphql": "^16.0.0",
"graphql-ws": ">= 4.5.0"
},
"peerDependenciesMeta": {
Expand Down
2 changes: 1 addition & 1 deletion packages/graphiql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@graphiql/react": "^0.26.2"
},
"peerDependencies": {
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2",
"graphql": "^16.0.0",
"react": "^16.8.0 || ^17 || ^18",
"react-dom": "^16.8.0 || ^17 || ^18"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/graphql-language-service-cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"LSP"
],
"peerDependencies": {
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2"
"graphql": "^16.0.0"
},
"dependencies": {
"@babel/polyfill": "^7.12.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/graphql-language-service-server/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"module": "esm/index.js",
"typings": "esm/index.d.ts",
"peerDependencies": {
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2"
"graphql": "^16.0.0"
},
"COMMENT": "please do not remove dependencies without thorough testing. many dependencies are not imported directly, as they are peer dependencies",
"dependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/graphql-language-service/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"graphql": "./dist/temp-bin.js"
},
"peerDependencies": {
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2"
"graphql": "^16.0.0"
},
"dependencies": {
"debounce-promise": "^3.1.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/monaco-graphql/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@
"vscode-languageserver-types": "^3.17.1"
},
"peerDependencies": {
"graphql": "^15.5.0 || ^16.0.0 || ^17.0.0-alpha.2",
"graphql": "^16.0.0",
"monaco-editor": ">= 0.20.0 < 1",
"prettier": "^2.8.0 || ^3.0.0"
}
Expand Down

0 comments on commit 6b88593

Please sign in to comment.