Include source code in all packages to fix source maps. #2047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2ccf852 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
willstott101
force-pushed
the
include-source
branch
from
1089bcf
to
2ccf852
Compare
Codecov Report
@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
- Coverage 65.70% 64.19% -1.52%
==========================================
Files 85 94 +9
Lines 5106 5424 +318
Branches 1631 1709 +78
==========================================
+ Hits 3355 3482 +127
- Misses 1747 1937 +190
- Partials 4 5 +1
Continue to review full report at Codecov.
|
|
Sorry, deploy previews for forked PRs are failing currently, it doesn’t impact this PR anyways |
|
Awesome! Getting this out today |
Merged
|
Thanks for the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently some build tools (cough react-scripts on webpack 5 cough) error out when trying to build source maps for the graphiql packages. This makes development much harder than it needs to be. By including the source code in the packages we build, the source maps are more likely to work...