GraphQL 16.7.0 breaks Vue3/Vite3 #3921
Comments
Closed
4 tasks
IvanGoncharov
added a commit
that referenced
this issue
Jun 22, 2023
Fixes: #3919 #3920 #3921 Context: #3887 changed code and introced optinal chaining. `globalThis.process?.env.NODE_ENV` is transpiled into ``` (_globalThis$process = globalThis.process) === null || _globalThis$process === void 0 ? void 0 : _globalThis$process.env.NODE_ENV; ``` Bundlers incorrectly replace (probably RegExp) `process.env.NODE_ENV` with `"development"` resulting in: ``` (_globalThis$process = globalThis.process) === null || _globalThis$process === void 0 ? void 0 : _globalThis$"development"; ``` Technically it's not a graphql issue but an issue with bundler but since it caused so much pain in comutinity this is an attempt to fix it within our codebase.
IvanGoncharov
added a commit
that referenced
this issue
Jun 22, 2023
|
@UglyHobbitFeet It's an issue with Vue internals but I added a workaround for it in |
|
confirmed, it is fixed!
…On Thu, Jun 22, 2023 at 1:20 PM Ivan Goncharov ***@***.***> wrote:
@UglyHobbitFeet <https://github.com/UglyHobbitFeet> It's an issue with
Vue internals but I added a workaround for it in 16.7.1 Can please
confirm that it is fixed?
—
Reply to this email directly, view it on GitHub
<#3921 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALBDS7QQTAGDT5L6CNGHLFDXMR5HNANCNFSM6AAAAAAZQJHAJQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@UglyHobbitFeet Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I upgrade my package.json, Vue no longer works as expected. (I get a blank screen instead of rendering my html/divs). Depending on browser console output I get a different error:
Chrome: Error with npm: [vite] Internal server error: Unexpected string
Firefox: Parsing error in the graphql stuff. Missing a )
The text was updated successfully, but these errors were encountered: