Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert flow types to TS #2828

Closed
wants to merge 65 commits into from
Closed

Convert flow types to TS #2828

wants to merge 65 commits into from

Commits on Apr 15, 2021

  1. rename .js to .ts 

    using this `find src -name "*.js" -exec sh -c 'git mv "$0" "${0%.js}.ts"' {} \;` shell command renamed all files in `src`
    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    6c2db84 View commit details
    Browse the repository at this point in the history

  2. convert flow's exact object type to TS

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    46130e9 View commit details
    Browse the repository at this point in the history

  3. convert $ReadonlyArray (flow) to ReadonlyArray (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    b7fdc96 View commit details
    Browse the repository at this point in the history

  4. convert + (flow) to readonly (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    3ab7ecf View commit details
    Browse the repository at this point in the history

  5. convert mixed (flow) to unknown (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    4dde86c View commit details
    Browse the repository at this point in the history

  6. convert ? (flow) to Maybe (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    78c2be0 View commit details
    Browse the repository at this point in the history

  7. remove ... (flow)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    65c2257 View commit details
    Browse the repository at this point in the history

  8. convert : (flow) with extends (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    ea8237f View commit details
    Browse the repository at this point in the history

  9. strip %checks annotations (flow)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    0ae46e0 View commit details
    Browse the repository at this point in the history

  10. convert flow type spread to & (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    b979e23 View commit details
    Browse the repository at this point in the history

  11. remove + (flow) annotations

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    554570d View commit details
    Browse the repository at this point in the history

  12. replace $PropertyType (flow)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    bd02097 View commit details
    Browse the repository at this point in the history

  13. remove <> (flow) from unions

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    20d18f4 View commit details
    Browse the repository at this point in the history

  14. refactor: TS function overloading

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    3c5aca9 View commit details
    Browse the repository at this point in the history

  15. Type convertion : (flow) to as in TS

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    64781a9 View commit details
    Browse the repository at this point in the history

  16. convert {...} (flow) to { } (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    e4e9b0c View commit details
    Browse the repository at this point in the history

  17. build: relax tsconfig

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    a6376bc View commit details
    Browse the repository at this point in the history

  18. make memoize arguments type weakmap

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    b62fe3d View commit details
    Browse the repository at this point in the history

  19. convert$ReadOnly (flow) to Readonly (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    c063d56 View commit details
    Browse the repository at this point in the history

  20. convert $Values (flow) to keyof (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    f491016 View commit details
    Browse the repository at this point in the history

  21. remove <> (flow)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    fdc57c8 View commit details
    Browse the repository at this point in the history

  22. convert $Shape (flow) to Partial (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    21d05da View commit details
    Browse the repository at this point in the history

  23. convert $Keys (flow) to keyof (TS)

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    257a3c7 View commit details
    Browse the repository at this point in the history

  24. enable tests by adding babel ts tranform plugin 

    remove flow plugin
    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    0212283 View commit details
    Browse the repository at this point in the history

  25. test: disable flow integration test

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    1599a69 View commit details
    Browse the repository at this point in the history

  26. build: ignore .d.ts files linting

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    e05758a View commit details
    Browse the repository at this point in the history

  27. style: run eslint fix and prettier

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    ec59c6e View commit details
    Browse the repository at this point in the history

  28. remove $ObjMap (flow) to fix visitor types

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    ba4c76e View commit details
    Browse the repository at this point in the history

  29. build: remove eslint flow plugin

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    8de679b View commit details
    Browse the repository at this point in the history

  30. refactor: remove unused eslint-disable directives

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    cb08f35 View commit details
    Browse the repository at this point in the history

  31. refactor: remove Flow Fix me comments

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    8f2ab17 View commit details
    Browse the repository at this point in the history

  32. feat: remove flow infrastructure

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    b07f73a View commit details
    Browse the repository at this point in the history

  33. build: rename to TS eslint rules and temporarily disable eslint rules

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    a05b95d View commit details
    Browse the repository at this point in the history

  34. build: enable @typescript-eslint/no-unused-vars

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    37a41f6 View commit details
    Browse the repository at this point in the history

  35. build: enable @typescript-eslint/no-invalid-void-type

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    f4f0440 View commit details
    Browse the repository at this point in the history

  36. build: enable @typescript-eslint/no-inferrable-types

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    039def9 View commit details
    Browse the repository at this point in the history

  37. build: enable @typescript-eslint/non-nullable-type-assertion-style

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    570b559 View commit details
    Browse the repository at this point in the history

  38. build: enable @typescript-eslint/no-unnecessary-type-assertion

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    cd91f2a View commit details
    Browse the repository at this point in the history

  39. build: enable @typescript-eslint/consistent-type-definitions

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    207e434 View commit details
    Browse the repository at this point in the history

  40. build: enable @typescript-eslint/consistent-type-imports

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    63a1798 View commit details
    Browse the repository at this point in the history

  41. match .d.ts definition

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    d490f3d View commit details
    Browse the repository at this point in the history

  42. fix: TS2355 function whose declared type is neither 'void' nor 'any' … 

    …must return a value

Co-Authored-By: Kamil Kisiela <[email protected]>
    @saihaj @kamilkisiela
    saihaj and kamilkisiela committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    1d9a8f9 View commit details
    Browse the repository at this point in the history

  43. convert ObjMap to use Record 

    Co-Authored-By: Kamil Kisiela <[email protected]>
    @saihaj @kamilkisiela
    saihaj and kamilkisiela committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    99e029f View commit details
    Browse the repository at this point in the history

  44. refactor: CoercedVariableValues type into union of interfaces 

    Co-Authored-By: Kamil Kisiela <[email protected]>
    @saihaj @kamilkisiela
    saihaj and kamilkisiela committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    462d04d View commit details
    Browse the repository at this point in the history

  45. refactor: convert to use Record 

    Co-Authored-By: Kamil Kisiela <[email protected]>
    @saihaj @kamilkisiela
    saihaj and kamilkisiela committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    89861c5 View commit details
    Browse the repository at this point in the history

  46. refactor: ensureArray func to return proper typed values 

    Co-Authored-By: Kamil Kisiela <[email protected]>
    @saihaj @kamilkisiela
    saihaj and kamilkisiela committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    59971b9 View commit details
    Browse the repository at this point in the history

  47. feat: typecast to ensure type safety 

    Co-Authored-By: Kamil Kisiela <[email protected]>
    @saihaj @kamilkisiela
    saihaj and kamilkisiela committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    d7f9f69 View commit details
    Browse the repository at this point in the history

  48. feat: type guard isObjectLike to Record 

    Co-Authored-By: Kamil Kisiela <[email protected]>
    @saihaj @kamilkisiela
    saihaj and kamilkisiela committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    58185c6 View commit details
    Browse the repository at this point in the history

  49. test: use @ts-expect-error 

    Co-Authored-By: Kamil Kisiela <[email protected]>
    @saihaj @kamilkisiela
    saihaj and kamilkisiela committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    a43cbd0 View commit details
    Browse the repository at this point in the history

  50. build: add @types/node

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    8dbbcac View commit details
    Browse the repository at this point in the history

  51. feat: use in operator to check TS type while doing boolean checks 

    Co-Authored-By: Kamil Kisiela <[email protected]>
    @saihaj @kamilkisiela
    saihaj and kamilkisiela committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    9ad53e8 View commit details
    Browse the repository at this point in the history

  52. TODO: need to fix these TS errors

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    e021f1b View commit details
    Browse the repository at this point in the history

  53. build + CI: add TS type check script

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    abd7a03 View commit details
    Browse the repository at this point in the history

  54. build: add @types/mocha

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    329334a View commit details
    Browse the repository at this point in the history

  55. build: add @types/chai

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    261b381 View commit details
    Browse the repository at this point in the history

  56. remove $FlowExpectedError[incompatible-call]

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    44222dc View commit details
    Browse the repository at this point in the history

  57. style: run prettier

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    99921a3 View commit details
    Browse the repository at this point in the history

  58. TODO: add @ts-expect-error fix me

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    d4aa269 View commit details
    Browse the repository at this point in the history

  59. feat: Mutable type utility

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    81363f1 View commit details
    Browse the repository at this point in the history

  60. TS: improve types mapAsyncIterator-test

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    fee1315 View commit details
    Browse the repository at this point in the history

  61. fix: instanceOf types

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    738956e View commit details
    Browse the repository at this point in the history

  62. fix: invariant types

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    23aba04 View commit details
    Browse the repository at this point in the history

  63. fix: ProvidedRequiredArgumentsRule types

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    948f656 View commit details
    Browse the repository at this point in the history

  64. fix: introspection type

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    72b5a98 View commit details
    Browse the repository at this point in the history

  65. add eslint-disable comment

    @saihaj
    saihaj committed Apr 15, 2021
    Configuration menu
    Copy the full SHA
    43ce601 View commit details
    Browse the repository at this point in the history