Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incrementalDelivery: refactoring and streamlining #3728

Merged
merged 4 commits into from
Sep 28, 2022
Merged

incrementalDelivery: refactoring and streamlining #3728

merged 4 commits into from
Sep 28, 2022
+39 −48

Commits on Sep 28, 2022

  1. refactor: move executeStreamField out of try 

    this function should catches errors and should never throw
    @yaacovCR
    yaacovCR committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    419fd37 View commit details
    Browse the repository at this point in the history

  2. refactor: use handleFieldError return value

    @yaacovCR
    yaacovCR committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    2991c79 View commit details
    Browse the repository at this point in the history

  3. rename fieldPath to itemPath

    @yaacovCR
    yaacovCR committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    71a8db4 View commit details
    Browse the repository at this point in the history

  4. skip unnecessary filtering 

    if the asyncIterator's next method throws, no incremental payloads for the result are possible, similar to completing an asyncIterator without stream
    @yaacovCR
    yaacovCR committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    4df02ca View commit details
    Browse the repository at this point in the history