Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(incrementalDelivery): fix null bubbling with async iterables #3760

Merged
merged 2 commits into from
Oct 27, 2022
Merged

fix(incrementalDelivery): fix null bubbling with async iterables #3760

merged 2 commits into from
Oct 27, 2022

Commits on Oct 18, 2022

  1. fix(incrementalDelivery): add additional tests 

    When a non-null list is streamed and completeValue for a list item
fails, the error should bubble up to the list itself and no further
payloads should be sent.

Addition of tests within this change demonstrates that this is currently
the case only when the field resolver for the list returns an iterable,
but not when it returns an async iterable. In the latter case, the null
correctly bubbles to the list itself for the given payload (`items:
null` rather than `items: [null`), but further payloads are sent.
    @yaacovCR
    yaacovCR committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    04a94fb View commit details
    Browse the repository at this point in the history

  2. fix(incrementalDelivery) fixes null bubbling for async iterables 

    when a null bubbles up, no further payloads should be sent.
    @yaacovCR
    yaacovCR committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    b020207 View commit details
    Browse the repository at this point in the history