extendSchema: preserve "description" and "extensions" #3776
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋
Closes #3629
Current behavior:
When calling
extendSchema(schema, schemaModification)
, extended schema description is calculated asschemaDef?.description?.value
, whereschemaDef
is a nullable schema definition, that will not be null only ifschemaModification
declares thetype schema
(it happens only when we callbuildSchema
or callextendSchema(schema, 'extend type __Schema { ... }')
)schemaDef?.description
is not undefined only whenextendSchema
is called frombuildSchema
, otherwise it's undefined because we don't allow a construction like:As a result, every
extendSchema
call besides the one inbuildSchema
will causedescription
to becomeundefined
Proposed solution:
Always fallback to the original schema description:
description: schemaDef?.description?.value ?? schemaConfig.description
It will allow us to make sure that we take a description from
schemaDef
when schema is being built and take original schema description in any other cases