Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: fix website build error #3843

Merged
merged 1 commit into from
Feb 6, 2023
Merged

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Feb 6, 2023

@netlify
Copy link

netlify bot commented Feb 6, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 01ababa
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/63e0cffcc93e7e0009fd8ba0
😎 Deploy Preview https://deploy-preview-3843--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR
Copy link
Contributor Author

yaacovCR commented Feb 6, 2023

@saihaj @benjie

This seems to fix the problem with build script on netlify missing the internal eslint rules => they were not previously being copied to the temporary folder.

Why then was the build script ever able to complete successfully? I am not sure. Perhaps somehow the package was in the cache on some earlier run and the cache expired?

@yaacovCR yaacovCR changed the title attempt to defeat netlify internal: fix netlify build error Feb 6, 2023
@yaacovCR yaacovCR changed the title internal: fix netlify build error internal: fix website build error Feb 6, 2023
@yaacovCR yaacovCR requested a review from a team February 6, 2023 10:06
Copy link
Member

@saihaj saihaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we shouldn't even need to copy any eslint things. We just run build of docusaurus and output things out but @IvanGoncharov would know why we decided to do this 🤔

Copy link
Member

@benjie benjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems harmless enough... Thanks Yaacov!

@yaacovCR yaacovCR merged commit b5eb498 into graphql:main Feb 6, 2023
@yaacovCR yaacovCR deleted the netlify-defeat branch February 6, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants