-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
internal: fix website build error #3843
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
This seems to fix the problem with build script on netlify missing the internal eslint rules => they were not previously being copied to the temporary folder. Why then was the build script ever able to complete successfully? I am not sure. Perhaps somehow the package was in the cache on some earlier run and the cache expired? |
1cf2b25
to
01ababa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we shouldn't even need to copy any eslint things. We just run build of docusaurus and output things out but @IvanGoncharov would know why we decided to do this 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems harmless enough... Thanks Yaacov!
#3840