Drop support for node14 #3855
Merged
Drop support for node14 #3855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanGoncharov
added
the
PR: breaking change 💥
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @IvanGoncharov, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
IvanGoncharov
force-pushed
the
pr_branch
branch
from
c23e1ba
to
be06750
Compare
Motivation: technically node14 end of life will happen in two months so we can still support it but it creates problems with graphql#3791 Node14 doesn't support `AbortSignal` and since we want to allow resolvers to be canceled we need to expose this object through our public API (inside `info` argument). Potentialy this and all the other issues (e.g. how to test this feature on node14) can be worked around but complicates solution. So I think, it worth to deprecate node14 two months earlier in order to unblock graphql#3791 especially since we still in alpha stage. Less critical but still significant problem with node14 is that it ships with npm6 which doesn't support default format of the lockfile used by npm9 and this make updating dependencies trickier.
IvanGoncharov
force-pushed
the
pr_branch
branch
from
be06750
to
da0a0d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation: technically node14 end of life will happen in two months so we can still support it but it creates problems with #3791 Node14 doesn't support
AbortSignaland since we want to allow resolvers to be canceled we need to expose this object through our public API (insideinfoargument). Potentialy this and all the other issues (e.g. how to test this feature on node14) can be worked around but complicates solution. So I think, it worth to deprecate node14 two months earlier in order to unblock #3791 especially since we still in alpha stage.Less critical but still significant problem with node14 is that it ships with npm6 which doesn't support default format of the lockfile used by npm9 and this make updating dependencies trickier.