Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getIntrospectionQuery should select kind for all types #3910

Closed
wants to merge 1 commit into from
Closed

getIntrospectionQuery should select kind for all types #3910

wants to merge 1 commit into from

Conversation

jonapgar-groupby
Copy link

Prior to this change, the result when using the getIntrospectionQuery does not match the declared IntrospectionQuery type.

Fixes #3909

@linux-foundation-easycla
Copy link

CLA Not Signed

@netlify
Copy link

netlify bot commented Jun 9, 2023 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit a4e6315
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/648357766581410007bcd3f3
😎 Deploy Preview https://deploy-preview-3910--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@yaacovCR yaacovCR mentioned this pull request Sep 27, 2024
Open
17 tasks
@yaacovCR
Copy link
Contributor

I think this is a legitimate bug. I guess the current behavior is working as is because the root types in a valid schema are always object types, but then we should have a different typing.

I am fine with either changing the typing on the root types to something specific where the Kind is not present, or this fix in asking for the Kind, preferring this fix, as in theory -- I think -- it is possible to introspect an invalid schema.

To proceed we will need to:

  1. Get the CLA signed.
  2. Rebase against v16.x.x or main (and after merge, we can port to the other branch).

@yaacovCR
Copy link
Contributor

@jonapgar-groupby

I know this is from a while back, thank you for your contribution and apologies for the delay!

We are currently trying to clean up our PR backlog, let us know if you are still interested in working on this!

@JoviDeCroock JoviDeCroock mentioned this pull request Oct 10, 2024
Merged
JoviDeCroock added a commit that referenced this pull request Oct 11, 2024
@JoviDeCroock
Include kind in the types (#4222)
6a379a5 
Supersedes #3910
Fixes #3909
Fixes #3409

This puts the Selection-set in line with the expected type
@JoviDeCroock
Copy link
Member

Fixed in #4222

@JoviDeCroock JoviDeCroock mentioned this pull request Oct 11, 2024
Merged
JoviDeCroock added a commit that referenced this pull request Oct 13, 2024
@JoviDeCroock
Backport introspection type fix (#4226)
2562ce0 
Backports #4222
Supersedes #3910
Fixes #3909
Fixes #3409
erikwrede pushed a commit to erikwrede/graphql-js that referenced this pull request Oct 17, 2024
@JoviDeCroock @erikwrede
Include kind in the types (#4222)
99ada95 
Supersedes graphql/graphql-js#3910
Fixes graphql/graphql-js#3909
Fixes graphql/graphql-js#3409

This puts the Selection-set in line with the expected type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getIntrospectionQuery result does not match the IntrospectionQuery type
3 participants
@jonapgar-groupby @yaacovCR @JoviDeCroock