Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: suppress records for deferred fragments that are completely empty #3984

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Nov 7, 2023

i.e. no fields and no enclosed deferred fragments

These fragments can be thought of to be completely skipped, because including them will just result in emitting metadata but no actual data. Alternatively, these fragments can be thought of as being inlined.

This could probably be considered a bug fix, in that Example F @ graphql/defer-stream-wg#69 explicitly states that these fragments should be skipped.

…y empty

i.e. no fields and no enclosed deferred fragments
@yaacovCR yaacovCR added the PR: bug fix 🐞 requires increase of "patch" version number label Nov 7, 2023
Copy link

netlify bot commented Nov 7, 2023

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 4fae1d0
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/654a15e46a44320008db95f0
😎 Deploy Preview https://deploy-preview-3984--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Nov 7, 2023

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the title do not emit pending records for deferred fragments that are completely empty fix: suppress records for deferred fragments that are completely empty Nov 7, 2023
@yaacovCR yaacovCR merged commit 2e29180 into graphql:main Nov 7, 2023
21 checks passed
@yaacovCR yaacovCR deleted the suppress-empty branch November 7, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: bug fix 🐞 requires increase of "patch" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants