-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow nested defers at the same level #4002
Conversation
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
This comment has been minimized.
This comment has been minimized.
@yaacovCR The latest changes of this PR are available on NPM as Also you can depend on latest version built from this PR: |
This is the starting point for #4026, a major rewrite of incremental delivery with the aim of following the spec edits at graphql/graphql-spec#1077 Considering that, if we are confident #4026 will get merged, this PR becomes important less for the implementation, and more for the test changes. |
if we allow nesting of defers at the same level then we have to handle the case where a defer is completely empty -- not just empty because its fields are also contained within a parent. this means that collectFields must directly return the new defer usages so that even empty defer usages can be used to create fragments so that we can track their children
Implements Option A from graphql/defer-stream-wg#80