polish(incremental): rename terms to match spec #4148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
JoviDeCroock
approved these changes
Jul 18, 2024
yaacovCR
force-pushed
the
the-great-renaming
branch
from
274870e
to
2466356
Compare
|
I should make clear that this PR is to match the spec draft WIP at graphql/graphql-spec#1077 and not the actual working draft of the spec, which does not yet have incremental delivery at all. |
yaacovCR
force-pushed
the
the-great-renaming
branch
from
f1453cd
to
619cb4f
Compare
robrichard
reviewed
Jul 23, 2024
robrichard
reviewed
Jul 23, 2024
DeferredGroupedFieldSet => PendingExecutionGroup DeferredGroupedFieldSetResult => CompletedExecutionGroup ReconcilableDeferredGroupedFieldSetResult => SuccessfulExecutionGroup NonReconcilableDeferredGroupedFieldSetResult => FailedExecutionGroup
SubsequentResultRecord => DeliveryGroup
got to watch that match case setting with mis-capitalizations
yaacovCR
force-pushed
the
the-great-renaming
branch
from
1f44a7c
to
fcc4ccd
Compare
robrichard
approved these changes
Jul 24, 2024
JoviDeCroock
added
the
PR: polish 💅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DeferredGroupedFieldSet => ExecutionGroup
SubsequentResultRecord => DeliveryGroup
ExecuteExecutionGroups => CollectExecutionGroups