improve new leaf type parseConstLiteral() method
#4218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaacovCR
added
the
PR: polish 💅
✅ Deploy Preview for compassionate-pike-271cb3 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋 Supported commandsPlease post this commands in separate comments and only one per comment:
|
yaacovCR
changed the title
parseConstValue() method to coerceInputLiteral()parseConstLiteral() method
yaacovCR
changed the title
parseConstLiteral() methodparseConstLiteral() method
JoviDeCroock
approved these changes
Oct 13, 2024
yaacovCR
force-pushed
the
rename-leaf-type-methods
branch
from
71b6b66
to
cd6f9f6
Compare
following convention suggested in graphql#2357
yaacovCR
force-pushed
the
rename-leaf-type-methods
branch
from
cd6f9f6
to
e69fd0d
Compare
This was referenced Oct 15, 2024
yaacovCR
added a commit
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the new method was introduced in #3812 with upgrade path improved in #4209.
This PR completes polishes this work a bit:
coerceInputLiteral()following the naming convention suggested in Rename Coercion functions #2357, with the other methods to be renamed in later PRs.GraphQLScalarInputLiteralCoerceris exported, which was not done in the initial work. The oldGraphQLScalarLiteralParsertype is deprecated.