Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the enhanced error messages regarding using multiple versions of graphql-js. #4238

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yaacovCR
Copy link
Contributor

This PR removes the enhanced error messages regarding using multiple versions of graphql-js.

Motivation:

Downside:

  • Removes helpful error messages in tricky-to-debug cases where build tools/frameworks/consumers may end up inadvertently using multiple versions of graphql. While the fixes for this error have gotten easier now that additional package management tools have adopted the ability to set resolutions/overrides, and awareness around this issue has perhaps increased, this change will cause more opaque error messages in that hopefully dwindling number of cases.

This PR should be thought of a strawman PR for discussion.

If we do want to re-enter the package management business to some extent, we could combine this with #3915 => although that PR would only protect us going forward with versions that will support Symbol.for().

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit 3a3b7e8
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/670e1e3bea8fb60008899825
😎 Deploy Preview https://deploy-preview-4238--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR added the PR: breaking change 💥 implementation requires increase of "major" version number label Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: breaking change 💥 implementation requires increase of "major" version number
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant