Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

introduce completeMaybePromisedListItemValue #4264

Closed
wants to merge 1 commit into from
Closed

introduce completeMaybePromisedListItemValue #4264

wants to merge 1 commit into from

Conversation

yaacovCR
Copy link
Contributor

@yaacovCR yaacovCR commented Oct 29, 2024 •
edited
Loading

depends on #4266

  • unifies some logic between completing sync and async iterables
  • gets rid of a few c8 ignore directives

@yaacovCR yaacovCR added the PR: polish 💅 PR doesn't change public API or any observed behaviour label Oct 29, 2024
@yaacovCR yaacovCR requested a review from a team as a code owner October 29, 2024 10:03
@netlify Netlify
Copy link

netlify bot commented Oct 29, 2024 •
edited
Loading

✅ Deploy Preview for compassionate-pike-271cb3 ready!

Name Link
🔨 Latest commit c16d429
🔍 Latest deploy log https://app.netlify.com/sites/compassionate-pike-271cb3/deploys/6720c4c7117b3200080f15f2
😎 Deploy Preview https://deploy-preview-4264--compassionate-pike-271cb3.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

Hi @yaacovCR, I'm @github-actions bot happy to help you with this PR 👋

Supported commands

Please post this commands in separate comments and only one per comment:

  • @github-actions run-benchmark - Run benchmark comparing base and merge commits for this PR
  • @github-actions publish-pr-on-npm - Build package from this PR and publish it on NPM

@yaacovCR yaacovCR changed the base branch from main to move-errors-to-wrapped-result October 29, 2024 11:20
@yaacovCR
Copy link
Contributor Author

yaacovCR commented Oct 29, 2024 •
edited
Loading

I have changed the base to #4266

This PR on its own seemed to lead to a drop in performance only in the case of async iterators, as does #4266, but when combined, there is no drop in performance.

image

This was referenced Oct 29, 2024
Closed
Merged
@yaacovCR
Copy link
Contributor Author

was able to remove this from the #4267 stack

@yaacovCR yaacovCR closed this Oct 29, 2024
@yaacovCR yaacovCR deleted the introduce-complete-maybe branch November 1, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
PR: polish 💅 PR doesn't change public API or any observed behaviour
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yaacovCR @JoviDeCroock