Extensions not shown in response

[robrichard]

I found old issues (#651 & #303) that suggest this was fixed at some point, but it looks like it is broken again. With "tracing.hideTracingResponse" set to either true or false, all extensions are hidden from the results window in version 1.6.0

This issue pertains to the following package(s):

• GraphQL Playground - Electron App
• GraphQL Playground HTML
• GraphQL Playground
• GraphQL Playground Express Middleware
• GraphQL Playground Lambda Middleware
• GraphQL Playground Koa Middleware
• GraphQL Playground Hapi Middleware

What OS and OS version are you experiencing the issue(s) on?

macOS 10.13.5

What version of graphql-playground(-electron/-middleware) are you experiencing the issue(s) on?

graphql-playground-middleware-koa

What is the expected behavior?

I see the complete response in the result window

What is the actual behavior?

The result window response does not match the network response, specifically, it swallows the extensions: { duration } object.

What steps may we take to reproduce the behavior?

Minimal example:

const Koa = require('koa')
const mount = require('koa-mount')
const cors = require('@koa/cors')
const graphqlHTTP = require('koa-graphql')
const koaPlayground = require('graphql-playground-middleware-koa').default
const opn = require('opn')
const getPort = require('get-port')
const app = new Koa()

const { buildSchema } = require('graphql')
const schema = buildSchema(`
type Query {
  hello: Hello,
}
type Hello {
  there: String
}
type Mutation {
  setHello(input: HelloInput!): Hello
}
input HelloInput {
  there: String!
}
`)

const db = {
  hello: {
    there: `General Kenobi!`
  }
}

const rootValue = {
  hello: () => db.hello,
  setHello: ({ hello }) => {
    previous = db.hello
    db.hello = hello
    return previous
  }
}

app.use(cors())

app.use(
  mount(
    '/graphql',
    graphqlHTTP(async (request) => {
      const start = Date.now()
      const extensions = ({ document, variables, operationName, result }) => ({
        duration: new Date() - start
      })
      return { schema, rootValue, extensions }
    })
  )
)

app.use(
  mount(
    '/playground',
    koaPlayground({
      endpoint: '/graphql'
    })
  )
)

getPort({ port: 4000 }).then(port => {
  app.listen(port, () => {
    const base = `http://localhost:${port}`
    console.log(`API: ${base}/graphql`)
    console.log(`Playground: ${base}/playground`)
    opn(`${base}/playground`)
  })
})

[curry684]

I can confirm that in Apollo Server 2.0, which pulls in @apollographql/[email protected], the traces never appear no matter the setting of that config option.

[robrichard]

I opened a PR to fix this: #813