Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show graphql extensions #813

Merged
merged 1 commit into from
Aug 23, 2018
Merged

Conversation

robrichard
Copy link
Contributor

Fixes #804.

Changes proposed in this pull request:

  • GraphQL Extensions are not always hidden from the results view.
  • When the tracing.hideTracingResponse setting is enabled, tracing is hidden from the results view as advertised in the docs.

@CLAassistant
Copy link

CLAassistant commented Aug 9, 2018

CLA assistant check
All committers have signed the CLA.

@robrichard robrichard mentioned this pull request Aug 9, 2018
7 tasks
@curry684
Copy link

That makes a lot more sense yes. I just don't get why the code was there in the first place, it wasted an hour of my life debugging why tracing wasn't working, because I had never even considered a development tool to just TRASH part of the output. Collapse by default, sure, but delete the entire extensions section... why?!?

@robrichard
Copy link
Contributor Author

@curry684 I had a similar experience. We add additional data to extensions (not tracing) and after updating to apollo-server@2 my first thoughts were that the custom extensions were not working. After debugging for some time, I discovered they were working but were being hidden by graphql-playground.

@robrichard
Copy link
Contributor Author

cc @timsuchanek who wrote the extension handling logic

@timsuchanek timsuchanek merged commit 15f9a2b into graphql:master Aug 23, 2018
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants