Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to disable share button #642

Merged
merged 1 commit into from
Apr 13, 2018
Merged

Add ability to disable share button #642

merged 1 commit into from
Apr 13, 2018

Conversation

sepehr500
Copy link
Contributor

Changes proposed in this pull request:

  • I would like to use graphql-playground on a project that has strict security requirements, and the share button's external request violates our rules. This pr exposes a prop called shareEnabled that will allow you to disable the share button.

@CLAassistant
Copy link

CLAassistant commented Apr 12, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@timsuchanek timsuchanek merged commit e7adb35 into graphql:master Apr 13, 2018
@timsuchanek
Copy link
Member

Thanks for the PR @sepehr500 !

@huv1k huv1k mentioned this pull request Apr 13, 2018
Closed
zhammer added a commit to zhammer/graphql-playground that referenced this pull request Jun 9, 2019
@zhammer
Set default shareEnabled to true
9ccfb8b 
- It seems like this was accidentally introduced in some UI fixes (graphql@273697e#diff-de99fb113c90fc40c0f1349bddf05b09)
- The PR (graphql#642) that added shareEnabled set default to true
- Resolves graphql#983
@zhammer zhammer mentioned this pull request Jun 9, 2019
Open
cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
@sepehr500 @timsuchanek
Add ability to remove share button (graphql#642)
1777aaa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huv1k huv1k huv1k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sepehr500 @CLAassistant @timsuchanek @huv1k