Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add programmatic tab renaming #744

Merged
merged 4 commits into from
Jun 26, 2018
Merged

Add programmatic tab renaming #744

merged 4 commits into from
Jun 26, 2018

Conversation

BrunoScheufler
Copy link
Contributor

Fixes #743 .

Changes proposed in this pull request:

  • Add optional name property to Tab interface

  • This property should be merged into the session by sessionFromTab on behalf of makeStateFromTabs

@BrunoScheufler BrunoScheufler changed the title Feature/add programmatical tab renaming Add programmatic tab renaming Jun 19, 2018
@timsuchanek timsuchanek merged commit 8556bd2 into graphql:master Jun 26, 2018
@BrunoScheufler BrunoScheufler deleted the feature/add-programmatical-tab-renaming branch June 26, 2018 09:23
@pobed2
Copy link

pobed2 commented Jul 9, 2018

@BrunoScheufler Should this be implemented in graphql-playground-html as well?

@BrunoScheufler
Copy link
Contributor Author

I'm not entirely sure but I don't think this feature has a giant usage because it's for a very specific use case, I think it would be accessible for the most users with the react package. Is there any reason why you're asking? 😄

cgxxv pushed a commit to cgxxv/graphql-playground that referenced this pull request Mar 25, 2022
* Fix announcement link

* Added name property to Tab interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants