send the subscription endpoint as parameter to link creator #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@fredr Hey, it looks good to me :), there are some legacy stuffs so I am glad that we are getting rid of it. So you can update types and documentation :) |
|
Excellent! Update coming soon 🍻 |
fredr
force-pushed
the
fix/apollo-link-subscription-endpoint
branch
2 times, most recently
from
02653eb
to
3895139
Compare
|
Updated, let me know if anything needs to change |
fredr
force-pushed
the
fix/apollo-link-subscription-endpoint
branch
from
3895139
to
4759abc
Compare
|
Looks good to me :) Thx for the PR 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #919
Changes proposed in this pull request:
Let me know if you think this is reasonable, and I'll update the type specifications and documentation to reflect this as well.