Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: deduplicated incremental delivery #1052

Closed
wants to merge 46 commits into from

Commits on Apr 28, 2023

  1. Configuration menu
    Copy the full SHA
    d12884e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    72d5447 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Configuration menu
    Copy the full SHA
    4d62b8b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. move Field Collection section earlier

    as it is used during ExecuteRootSelectionSet
    yaacovCR committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    8fd0df3 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2023

  1. enhance(ResolveFieldValue): add async collection language

    and some baseline collection language for comparison
    
    extracted from graphql#742
    
    Authored-by: Rob Richard <[email protected]>
    yaacovCR committed Dec 10, 2023
    Configuration menu
    Copy the full SHA
    f5e26e3 View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2024

  1. Introduce @stream.

    Authored-by: Rob Richard <[email protected]>
    Co-authored-by: Benjie Gillam <[email protected]>
    Co-authored-by: Yaacov Rydzinski <[email protected]>
    3 people committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    648bf34 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Introduce @defer.

    Authored-by: Rob Richard <[email protected]>
    Co-authored-by: Benjie Gillam <[email protected]>
    Co-authored-by: Yaacov Rydzinski <[email protected]>
    3 people committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    3677a09 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Add GetPending algorithm

    This is a simplified version of GetIncrementalResult useful for the initial result.
    
    Readers approaching the spec in order may benefit from a bit of repetition.
    yaacovCR committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    0b25562 View commit details
    Browse the repository at this point in the history
  2. fix nomenclature for GetParentAndParentDeferState

    pendingInfo => deferState
    
    as we now track ids separately from the defer state; the prior language was left over from an earlier branch
    yaacovCR committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    dc443e8 View commit details
    Browse the repository at this point in the history
  3. doc: add more prose for ProcessIncrementalDigests

    to explain why and how it manages defer ordering
    yaacovCR committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    8cc2507 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8c138b0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ea03b3c View commit details
    Browse the repository at this point in the history
  6. fix: remove unnecessary variable

    when releasing pending futures, they can simply be appended to remainingFutures, i.e. the uncompleted futures, for future processing after the pending is issued.
    yaacovCR committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    1be7a58 View commit details
    Browse the repository at this point in the history
  7. fix: change variable name to be consistent

    we should use newFutures to add a bit more specificity
    yaacovCR committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    d998aca View commit details
    Browse the repository at this point in the history
  8. fix typos in GetUpdatesForDeferredResult

    within the section for making sure we don't send incremental entries twice
    
    1. we need to iterate through the incremental entries that are being sent, not the completed entries
    
    2. we need to update the new pending incremental entries correctly.
    yaacovCR committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    b97a920 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2024

  1. Configuration menu
    Copy the full SHA
    a694666 View commit details
    Browse the repository at this point in the history
  2. remove Incremental Digests concept

    leaving just futures
    yaacovCR committed Jan 10, 2024
    Configuration menu
    Copy the full SHA
    6941ddd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa6e3df View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. fix how new defer usages are collected

    previously, we mutated a list (along with some other bugs)
    yaacovCR committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    21ef532 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. rewrite

    yaacovCR committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    74f2f57 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2024

  1. change to have an incremental update stream mapped to an incremental …

    …payload stream
    
    The update stream suppresses future completion that should not lead to a response, i.e. now all incremental entries for a given fragment have been completed.
    
    The payload stream does the response formatting.
    
    NOTE: I think it is possible that we can move payload response formatting out of the execution section entirely, and into the Response section.
    yaacovCR committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    ae882e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    19a4757 View commit details
    Browse the repository at this point in the history
  3. editorial change

    yaacovCR committed Jan 19, 2024
    Configuration menu
    Copy the full SHA
    a9e2d87 View commit details
    Browse the repository at this point in the history
  4. Fix typo

    yaacovCR authored Jan 19, 2024
    Configuration menu
    Copy the full SHA
    f43b57f View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Configuration menu
    Copy the full SHA
    986853f View commit details
    Browse the repository at this point in the history
  2. Remove GetNonEmptyParent

    yaacovCR committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    77c7846 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    69c9f5f View commit details
    Browse the repository at this point in the history
  4. fix mistake when setting count

    we start at the number of deferred fragments and then go down
    yaacovCR committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    0cf445e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    fa67030 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7c0fccf View commit details
    Browse the repository at this point in the history
  7. get rid of count and sent

    yaacovCR committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    19fbef6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3a14539 View commit details
    Browse the repository at this point in the history
  9. add some more magic

    yaacovCR committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    0d91637 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2024

  1. typo

    yaacovCR committed Jan 27, 2024
    Configuration menu
    Copy the full SHA
    d7906cf View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2024

  1. refine ReleaseFragment

    yaacovCR committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    4511190 View commit details
    Browse the repository at this point in the history
  2. complete renaming

    yaacovCR committed Jan 28, 2024
    Configuration menu
    Copy the full SHA
    a289616 View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Configuration menu
    Copy the full SHA
    63cf6c2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5e62f59 View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2024

  1. simplify

    yaacovCR committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    c00963d View commit details
    Browse the repository at this point in the history
  2. minor fixes to the major rewrite

    have to update the pendingFutures set when completing a fragment
    yaacovCR committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    19216eb View commit details
    Browse the repository at this point in the history
  3. switch line order

    yaacovCR committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    3ffa48a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6c289c4 View commit details
    Browse the repository at this point in the history
  5. finish renaming update

    yaacovCR committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    894b994 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3768025 View commit details
    Browse the repository at this point in the history
  7. fix reset of variable

    yaacovCR committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    4fc4dc1 View commit details
    Browse the repository at this point in the history
  8. fix variable name typo

    yaacovCR committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    a966583 View commit details
    Browse the repository at this point in the history