This repository has been archived by the owner on Dec 26, 2022. It is now read-only.
Use jq to extract the version of protoc that Pants uses
#2068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wimax-grapl
approved these changes
Oct 19, 2022
Rather than using `grep` on TOML to extract which version of `protoc` is being used (which works, but can be fragile), we will instead parse a gigantic JSON dump of Pants' state and extract the version using `jq`. This is more robust because it takes into account the layering that Pants uses (i.e., CLI options override `pants.toml` configuration, which in turn overrides hardcoded defaults). This means we don't even have to pin a version in `pants.toml` and the script will still work! For now, however, I *have* opted to keep the pin in `pants.toml`, purely for visibility and explicitness. Signed-off-by: Christopher Maier <[email protected]>
christophermaier
force-pushed
the
cm/extract-protoc-version-from-pants
branch
from
ac76320
to
78934a0
Compare
Codecov ReportBase: 39.37% // Head: 39.41% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2068 +/- ##
==========================================
+ Coverage 39.37% 39.41% +0.03%
==========================================
Files 436 434 -2
Lines 10155 10148 -7
==========================================
+ Hits 3999 4000 +1
+ Misses 6156 6148 -8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than using
grepon TOML to extract which version ofprotocis being used (which works, but can be fragile), we will instead parse a gigantic JSON dump of Pants' state and extract the version usingjq.This is more robust because it takes into account the layering that Pants uses (i.e., CLI options override
pants.tomlconfiguration, which in turn overrides hardcoded defaults). This means we don't even have to pin a version inpants.tomland the script will still work!For now, however, I have opted to keep the pin in
pants.toml, purely for visibility and explicitness.Signed-off-by: Christopher Maier [email protected]