This repository has been archived by the owner on Sep 9, 2022. It is now read-only.
Generate Timezone Options from Built-in PHP Function #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I looked into this code because I got PHP warnings about undefined constants in setup.php. They were caused by non-breaking whitespaces near "Choose..." and "Europe/Copenhagen" (<?php }\xa0?>) as I figured out later. In the meantime, I decided to replace the original code with a loop that generates the drop-down list from the list of time zones provided by the built-in PHP function timezone_identifiers_list().
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looked into this code because I got PHP warnings about undefined
constants in setup.php. They were caused by non-breaking whitespaces
near "Choose..." and "Europe/Copenhagen" () as I figured
out later.
In the meantime, I decided to replace the original code with a loop
that generates the drop-down list from the list of time zones provided
by the built-in PHP function timezone_identifiers_list().