Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tsh does not respect user field in profile #1047

Closed
russjones opened this issue Jun 6, 2017 · 0 comments
Closed

tsh does not respect user field in profile #1047

russjones opened this issue Jun 6, 2017 · 0 comments
Assignees
@russjones
Labels
bug
Milestone
2.2

Comments

@russjones
Copy link
Contributor

russjones commented Jun 6, 2017 •
edited
Loading

Problem

tsh does not respect the user field in ~/.tsh/profile.

Reproduction

  1. Configure Teleport to use OIDC or SAML.
  2. tsh --proxy=localhost login
  3. tsh --proxy=localhost ssh localhost

During Step 3 you will be redirected to your identity provider to login again because tsh only reads profiles if no proxy is set: https://github.com/gravitational/teleport/blob/master/tool/tsh/common/tsh.go#L514-L519

Solution

  • If --proxy is not set, read the ~/.tsh/profile symlink.
  • If --proxy is set, read profile from ~/.tsh/<proxy-addr>.yaml.

For both cases, after reading the profile, override the values with command line flags.
@russjones russjones added the bug label Jun 6, 2017
@russjones russjones added this to the 2.2 milestone Jun 6, 2017
@russjones russjones self-assigned this Jun 6, 2017
@russjones russjones mentioned this issue Jun 7, 2017
Merged
hatched pushed a commit to hatched/teleport-merge that referenced this issue Nov 30, 2022
@ravicious
CI: Fail if an update to yarn.lock is needed (gravitational#1047)
aa5c34e 
* CI: Fail if an update to yarn.lock is needed

* Clean up the lockfile
hatched pushed a commit that referenced this issue Dec 20, 2022
@ravicious
CI: Fail if an update to yarn.lock is needed (#1047)
ae51c87 
* CI: Fail if an update to yarn.lock is needed

* Clean up the lockfile
hatched pushed a commit that referenced this issue Feb 1, 2023
@ravicious
[v10] CI: Fail if an update to yarn.lock is needed (#1047) (#1056)
1ed9e47 
* CI: Fail if an update to yarn.lock is needed

* Clean up the lockfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@russjones russjones

Labels
bug
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
1 participant
@russjones