Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect: Remove proprietary imports from OSS build #17706

Closed
3 tasks
ravicious opened this issue Oct 24, 2022 · 3 comments · Fixed by #41036
Closed
3 tasks

Connect: Remove proprietary imports from OSS build #17706

ravicious opened this issue Oct 24, 2022 · 3 comments · Fixed by #41036
Assignees
Labels
teleport-connect Issues related to Teleport Connect.

Comments

@ravicious
Copy link
Member

ravicious commented Oct 24, 2022

  • Make sure the OSS build of Connect compiles.
  • Make sure yarn storybook works without fetching webapps.e first.
  • Add a step to CI which builds the OSS version of Connect.
    • This should be done in addition to building the enterprise version to ensure that both versions build successfully.

Ever since we added support for access requests (gravitational/webapps#1203), the OSS build of Connect has been broken. The app now unconditionally imports proprietary code which is not available for OSS users.

The temporary solution is to remove any imports that require code from e-teleterm and e-teleport. To do this, clone ravicious/connect-oss-workaround (#21794) and rebase it on top of master.

@ravicious ravicious added the teleport-connect Issues related to Teleport Connect. label Oct 24, 2022
@ravicious ravicious changed the title Connect: Fix propertiary imports in OSS build Connect: Fix proprietary imports in OSS build Oct 24, 2022
@ravicious ravicious changed the title Connect: Fix proprietary imports in OSS build Connect: Remove proprietary imports from OSS build Oct 24, 2022
@ravicious ravicious self-assigned this Jan 19, 2023
@ravicious
Copy link
Member Author

@avatus @gzdunek Here's my plan on how to fix the OSS build of Connect. Please leave any comments under the gist. I had to submit it as a gist instead of a comment here because of how GitHub handles Markdown in files vs comments. 🙄

@ravicious
Copy link
Member Author

I have to pause this work, we might come back to this issue by the end of April.

@gzdunek
Copy link
Contributor

gzdunek commented Apr 30, 2024

For posterity: instead of adding Connect Enterprise entry point (and increasing the project complexity), we decided to move the shared part of access requests UI to OSS.
Slack discussion https://gravitational.slack.com/archives/C02DQ1C2BMW/p1712927997067419

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
teleport-connect Issues related to Teleport Connect.
Projects
None yet
2 participants