Move the shared part of access requests UI to OSS #41036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last commit from teleport.e that includes the original files: gravitational/teleport.e@5ca6881
`accessRequestsService.test.ts` was refactored slightly, we don't need assumed requests there at all.
gzdunek
added
no-changelog
|
@gzdunek - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
1 similar comment
|
@gzdunek - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
ravicious
approved these changes
Apr 30, 2024
avatus
approved these changes
Apr 30, 2024
zmb3
approved these changes
Apr 30, 2024
public-teleport-github-review-bot
bot
removed the request for review
from kimlisa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17706
In this PR, we finally move the shared part of access requests UI to OSS. This will allow Connect to build without having an access to teleport.e.
Some of the files in
sharedstill import stuff fromteleport. This is not ideal (although we had them even before), but with Michael's upcoming work we may be able to get rid of some of them.I added a reference to the last commit from teleport.e to the first commit. From what I see, 'squash and merge' combines all commits' messages into a single message, so this information should be preserved.
Best to review commit by commit.