Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: SSO MFA - Add Auth Connector MFA settings protobuf and methods. #46687

Merged
merged 2 commits into from
Sep 30, 2024
Merged

feat: SSO MFA - Add Auth Connector MFA settings protobuf and methods. #46687

merged 2 commits into from
Sep 30, 2024

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Sep 17, 2024 •
edited
Loading

Part of the implementation of SSO MFA

@Joerger Joerger force-pushed the joerger/auth-connector-mfa-settings branch 2 times, most recently from f72c0f5 to f4f51dc Compare September 18, 2024 00:23
@Joerger Joerger marked this pull request as ready for review September 18, 2024 00:23
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@Joerger Joerger mentioned this pull request Sep 18, 2024
Open
@Joerger Joerger added the no-changelog Indicates that a PR does not require a changelog entry label Sep 18, 2024
This was referenced Sep 18, 2024
Draft
Open
@Joerger Joerger force-pushed the joerger/auth-connector-mfa-settings branch from f4f51dc to 3cf210a Compare September 21, 2024 00:24
@Joerger Joerger force-pushed the joerger/auth-connector-mfa-settings branch from 3cf210a to 798c5e3 Compare September 30, 2024 17:11
@Joerger
Copy link
Contributor Author

Joerger commented Sep 30, 2024

@fspmarshall friendly reminder for review

fspmarshall
fspmarshall approved these changes Sep 30, 2024
View reviewed changes
Copy link
Contributor

@fspmarshall fspmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At a glance it looks like at least one of the new fields is a secret. I don't know much about oidc/saml so I'm not sure which other fields may also be sensitive, but the OIDCConnector and SAMLConnector resources both implement the ResourceWithSecrets interface and implement separate RBAC controls for reading the resources with and without secrets included. In practice, what this means is that any time you add a field either of these resources, their respective WithoutSecrets method must be updated to censor/omit the field if it is secret/sensitive.

LGTM once a pass has been done on WithoutSecrets.

@Joerger Joerger added this pull request to the merge queue Sep 30, 2024
Merged via the queue into master with commit 9cd5083 Sep 30, 2024
41 of 42 checks passed
@Joerger Joerger deleted the joerger/auth-connector-mfa-settings branch September 30, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fspmarshall fspmarshall fspmarshall approved these changes

@kiosion kiosion kiosion approved these changes

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joerger @fspmarshall @kiosion