Increase feature slider height for smallest screens #47058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our empty state pages, we have this neat purple frame that slides over each feature. This gets very slightly wonky if the feature text is a bit too large. This just bumps up the height for the smallest screens to give a bit more breathing room to the text.
avatus
added
the
no-changelog
kimlisa
approved these changes
Oct 1, 2024
zmb3
approved these changes
Oct 1, 2024
public-teleport-github-review-bot
bot
removed the request for review
from gzdunek
avatus
added a commit
that referenced
this pull request
Oct 2, 2024
In our empty state pages, we have this neat purple frame that slides over each feature. This gets very slightly wonky if the feature text is a bit too large. This just bumps up the height for the smallest screens to give a bit more breathing room to the text.
avatus
added a commit
that referenced
this pull request
Oct 2, 2024
In our empty state pages, we have this neat purple frame that slides over each feature. This gets very slightly wonky if the feature text is a bit too large. This just bumps up the height for the smallest screens to give a bit more breathing room to the text.
avatus
added a commit
that referenced
this pull request
Oct 2, 2024
In our empty state pages, we have this neat purple frame that slides over each feature. This gets very slightly wonky if the feature text is a bit too large. This just bumps up the height for the smallest screens to give a bit more breathing room to the text.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 2, 2024
* Add new empty state for Bots page in the web UI (#46773) * Add new images * Shared EmptyState components * Add DisplayTile * Add Bots EmptyState component * Use EmptyState and update story/test * Update images with manual shadow design team removed shadows from images to make them consistant and requested manual shadows added for images (and not tile scene) * Fix fontsize * Update word * Add optional pagerPosition prop to device table (#47046) This adds an optional prop that is required for the new empty state tables (coming in an `e` PR) * Increase feature slider height for smallest screens (#47058) In our empty state pages, we have this neat purple frame that slides over each feature. This gets very slightly wonky if the feature text is a bit too large. This just bumps up the height for the smallest screens to give a bit more breathing room to the text.
avatus
added a commit
that referenced
this pull request
Oct 4, 2024
* Add new empty state for Bots page in the web UI (#46773) * Add new images * Shared EmptyState components * Add DisplayTile * Add Bots EmptyState component * Use EmptyState and update story/test * Update images with manual shadow design team removed shadows from images to make them consistant and requested manual shadows added for images (and not tile scene) * Fix fontsize * Update word * Add optional pagerPosition prop to device table (#47046) This adds an optional prop that is required for the new empty state tables (coming in an `e` PR) * Increase feature slider height for smallest screens (#47058) In our empty state pages, we have this neat purple frame that slides over each feature. This gets very slightly wonky if the feature text is a bit too large. This just bumps up the height for the smallest screens to give a bit more breathing room to the text.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our empty state pages, we have this neat purple frame that slides over each feature. This gets very slightly wonky if the feature text is a bit too long. This just bumps up the height for the smallest screens to give a bit more breathing room to the text.
Before
After
